-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pypi.yml #51
Update pypi.yml #51
Conversation
@@ -17,17 +17,32 @@ jobs: | |||
CIBW_SKIP: cp36-* | |||
- uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about just add poetry build
after pypa/cibuildwheel@v2.12.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Poetry build
run: poetry build && mv dist/*.tar.gz wheelhouse/
- uses: actions/upload-artifact@v3
with:
path: wheelhouse/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need single .tar.gz
file. If we add this steps after pypa/cibuildwheel@v2.12.0
it will be executed and created per each matrix.os
. It is not needed I guess, plus it will take more time.
Well, it will overwrite existing file each time, so not a big problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
@@ -17,17 +17,32 @@ jobs: | |||
CIBW_SKIP: cp36-* | |||
- uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
- uses: pypa/gh-action-pypi-publish@v1.6.4 | ||
with: | ||
user: __token__ | ||
password: ${{ secrets.pypi_password }} | ||
packages_dir: wheelhouse/artifact | ||
packages_dir: dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this include all whl files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes all .whl
files generated by pypa/cibuildwheel@v2.12.0
The .whl
files are stored to ./wheelhouse
dir, then content of ./wheelhouse
is uploaded as an artifact with name dist
, then in upload
job artifacts are downloaded and stored in directories which are named after artifact name e.g. in ./dist
for dist
artifact and in ./tar
for tar
artifact. Files created using matrix are merged in artifact, so all should be present as long as they have different names (and they do have different names).
Thanks! |
And I uploaded tar for 0.2.6 manually, so this can be used in next release |
This solves #50
Added job which creates
.tar.gz
distribution file. The file is stored with wheels just before upload to PyPi