Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pypi.yml #51

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Update pypi.yml #51

merged 1 commit into from
Jan 31, 2023

Conversation

dmitrii-begal
Copy link
Contributor

This solves #50
Added job which creates .tar.gz distribution file. The file is stored with wheels just before upload to PyPi

@@ -17,17 +17,32 @@ jobs:
CIBW_SKIP: cp36-*
- uses: actions/upload-artifact@v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just add poetry build after pypa/cibuildwheel@v2.12.0?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

      - name: Poetry build
        run: poetry build && mv dist/*.tar.gz wheelhouse/
      - uses: actions/upload-artifact@v3
        with:
          path: wheelhouse/

Copy link
Contributor Author

@dmitrii-begal dmitrii-begal Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need single .tar.gz file. If we add this steps after pypa/cibuildwheel@v2.12.0 it will be executed and created per each matrix.os. It is not needed I guess, plus it will take more time.
Well, it will overwrite existing file each time, so not a big problem.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

@@ -17,17 +17,32 @@ jobs:
CIBW_SKIP: cp36-*
- uses: actions/upload-artifact@v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

- uses: pypa/gh-action-pypi-publish@v1.6.4
with:
user: __token__
password: ${{ secrets.pypi_password }}
packages_dir: wheelhouse/artifact
packages_dir: dist
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include all whl files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This includes all .whl files generated by pypa/cibuildwheel@v2.12.0
The .whl files are stored to ./wheelhouse dir, then content of ./wheelhouse is uploaded as an artifact with name dist, then in upload job artifacts are downloaded and stored in directories which are named after artifact name e.g. in ./dist for dist artifact and in ./tar for tar artifact. Files created using matrix are merged in artifact, so all should be present as long as they have different names (and they do have different names).

@long2ice long2ice merged commit 32bd1c6 into long2ice:dev Jan 31, 2023
@long2ice
Copy link
Owner

Thanks!

@long2ice
Copy link
Owner

long2ice commented Jan 31, 2023

And I uploaded tar for 0.2.6 manually, so this can be used in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants