-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise for latest Wagtail and Django #474
base: master
Are you sure you want to change the base?
Modernise for latest Wagtail and Django #474
Conversation
Remove python 3.7
I have ignore the help_text for flake8 because extra migrations are required if you format it.
I am seeing errors sometimes with longclaw.test.tests.test_shipping.ShippingOptionEndpointTest
I wonder why they have appeared again?
There's some temporary fixes in place here until I can confirm all the features are working as expected.
Add codyhouse css and js cdn
Initial modernise integration
I've added GitHub Actions but have seen random failures with loading the countries there. It doesn't happen locally. |
This is a big PR. If it is tricky to fix all issues in this PR, I would suggest trying to break it up into more atomic updates. E.g one PR for updating wagtail, one PR for modernising tox and github actions and so on. 7 This will make it much easier to review and merge |
Thanks @JamesRamm Yep it's a big one 馃槃 you could say I got carried away but I think it shows the way forward. I'll find some time to break it down into smaller pieces of work so it can be reviewed easier and merge in bit by bit. |
@nickmoreton do you feel like going further with this PR? |
Hi @JamesRamm Yes I would. I鈥檝e not had time to work on it since the PR due to other work. I鈥檒l see what I can do to break it down into smaller pieces of work. |
Hi @JamesRamm I made a start: #485 What do you think? Thanks |
Working with Wagtail 4.1
This is a rework of the Longclaw master branch that adjusts the code for working with Wagtail 2.15+ but makes a few other changes, for now, to hopefully re-boot a Wagtail package that always looked so promising.
I am happy to hear any feedback 馃槃
What is fixed
It's opinionated but...
What not fixed / removed / broken
Although I haven't included some original code there's no reason It couldn't be added back in.