Deals with the deprecation of request.site in wagtail 2.9 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I don't know if you are able to merge? |
The merge button is disabled for me but probably because the travis-ci stage is waiting for status update. Do you know why that is? I’m not familiar with that service but it looks like it could do with some attention with the python versions and django versions but in the end looks like it’s used to publish the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the longclaw_demo I discovered a site middleware change that happens at v2.9 https://docs.wagtail.org/en/stable/releases/2.9.html#sitemiddleware-and-request-site-deprecated needs to be updated.
The current version support for the master branch is: wagtail>=2.11,<2.14, hence the changes here.
This updates package code and tests where request.site was used previously.