Support exporting backing image from volume #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 2403 Signed-off-by: Shuo Wu <shuo.wu@suse.com>
shuo-wu
force-pushed
the
bi-from-volume
branch
from
6e8997d
to
ab70b1d
Compare
joshimoo
previously approved these changes
Aug 20, 2021
pkg/util/util.go
Outdated
|
|
||
| func ExecuteWithTimeout(timeout time.Duration, envs []string, binary string, args ...string) (string, error) { | ||
| var err error | ||
| cmd := exec.Command(binary, args...) |
There was a problem hiding this comment.
NIT: You can use a CommandContext, then pass a context.withTimeout. This way you don't need the timeout go routine below.
Longhorn 2403 Signed-off-by: Shuo Wu <shuo.wu@suse.com>
…ing ready Signed-off-by: Shuo Wu <shuo.wu@suse.com>
shuo-wu
force-pushed
the
bi-from-volume
branch
from
ab70b1d
to
1318216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#2403