Avoid recording the pre-restore errors in syncagent server restore info #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshimoo
suggested changes
Aug 27, 2020
added 2 commits
August 28, 2020 16:52
…ore info 1. If `backupstore.RestoreDeltaBlockBackup` or `backupstore.RestoreDeltaBlockBackupIncrementally` fails, the restore is actually not performed. 2. Considering there may be file locking timeout error can be returned by the above functions, it's better not to record error and mark the replica as ERROR. Longhorn #1279 Signed-off-by: Shuo Wu <shuo@rancher.com>
Signed-off-by: Shuo Wu <shuo@rancher.com>
joshimoo
approved these changes
Aug 28, 2020
This was referenced Aug 28, 2020
Merged
|
This change was to differentiate between restore initiation failures and actual failures during the restore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion with @joshimoo, we need to avoid recording the errors before performing the actual restore. Otherwise, the related replica will be marked as ERROR once there is a restore file locking timeout, which is bad for the user experience.
longhorn/longhorn#1279