Object Storage (LEP 20230430) #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
m-ildefons
force-pushed
the
wip/object-store
branch
from
7cd7c6d
to
42fb542
Compare
17 tasks
|
This pull request is now in conflicts. Could you fix it @m-ildefons? 🙏 |
m-ildefons
force-pushed
the
wip/object-store
branch
2 times, most recently
from
d8639a5
to
58713df
Compare
m-ildefons
changed the title
m-ildefons
force-pushed
the
wip/object-store
branch
from
58713df
to
85c5472
Compare
PhanLe1010
previously approved these changes
Nov 16, 2023
PhanLe1010
reviewed
Nov 16, 2023
There was a problem hiding this comment.
LGTM
- Need to remove the replace directive in go.mod before merging
- Can we also do this Object Storage (LEP 20230430) longhorn-engine#934 (comment)
|
This pull request is now in conflicts. Could you fix it @m-ildefons? 🙏 |
m-ildefons
force-pushed
the
wip/object-store
branch
3 times, most recently
from
221a5ec
to
30eb76a
Compare
Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons
force-pushed
the
wip/object-store
branch
from
30eb76a
to
f2f3e68
Compare
Rebase on master and update vendored modules. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of backup functionality for the object store.
The object store consists of a normal longhorn volume and an object storage gateway (s3gw) instance. In case of a backup, the details of the object storage gateway deployment must be backed up as well, to be able to restore the entire object store. Therefore an object store backup carries additional metadata in the form of the deployment details of the object storage gateway.
Related: longhorn/longhorn#6640
Related: longhorn/longhorn-manager#2136
Related: longhorn/longhorn-engine#934
Related: longhorn/backupstore#148
Related: longhorn/longhorn-ui#649
LEP: longhorn/longhorn#5832