Skip to content

Commit

Permalink
Reject volume.spec.image update for v2 volumes before introducing liv…
Browse files Browse the repository at this point in the history
…e upgrade

Reject volume.spec.image update for v2 volumes before introducing live
upgrade (longhorn/longhorn#6001).

Longhorn 7446

Signed-off-by: Derek Su <derek.su@suse.com>
  • Loading branch information
derekbit authored and David Ko committed Dec 26, 2023
1 parent 35852f2 commit b9e6569
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions webhook/resources/volume/validator.go
Expand Up @@ -293,6 +293,12 @@ func (v *volumeValidator) Update(request *admission.Request, oldObj runtime.Obje
newVolume.Name, newVolume.Spec.BackendStoreDriver)
return werror.NewInvalidError(err.Error(), "")
}

if oldVolume.Spec.Image != newVolume.Spec.Image {
err := fmt.Errorf("changing engine image for volume %v is not supported for backend store driver %v",
newVolume.Name, newVolume.Spec.BackendStoreDriver)
return werror.NewInvalidError(err.Error(), "")
}
} else {
if newVolume.Spec.OfflineReplicaRebuilding != longhorn.OfflineReplicaRebuildingDisabled {
err := fmt.Errorf("changing offline replica rebuilding for volume %v is not supported for backend store driver %v",
Expand Down

0 comments on commit b9e6569

Please sign in to comment.