Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support local volume #1562

Merged
merged 8 commits into from Nov 25, 2022
Merged

feat: support local volume #1562

merged 8 commits into from Nov 25, 2022

Conversation

derekbit
Copy link
Member

Longhorn 3957

Signed-off-by: Derek Su derek.su@suse.com

@derekbit derekbit self-assigned this Nov 22, 2022
@derekbit derekbit force-pushed the local-volume branch 4 times, most recently from 512bfb7 to c4f6d3f Compare November 23, 2022 09:09
@derekbit derekbit marked this pull request as ready for review November 23, 2022 14:43
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. One comment needed to resolve.

manager/volume.go Outdated Show resolved Hide resolved
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
datastore/longhorn.go Show resolved Hide resolved
datastore/longhorn.go Outdated Show resolved Hide resolved
Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
…rocess

Longhorn 3957

Signed-off-by: Derek Su <derek.su@suse.com>
@innobead innobead merged commit 41a34f8 into longhorn:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants