New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support local volume #1562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
local-volume
branch
4 times, most recently
from
November 23, 2022 09:09
512bfb7
to
c4f6d3f
Compare
derekbit
requested review from
c3y1huang,
shuo-wu,
innobead,
mantissahz,
weizhe0422 and
a team
November 23, 2022 14:42
innobead
requested changes
Nov 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM. One comment needed to resolve.
derekbit
force-pushed
the
local-volume
branch
from
November 25, 2022 04:53
5428d50
to
3f61f27
Compare
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
force-pushed
the
local-volume
branch
from
November 25, 2022 04:55
3f61f27
to
976a206
Compare
innobead
requested changes
Nov 25, 2022
derekbit
force-pushed
the
local-volume
branch
from
November 25, 2022 05:05
976a206
to
52c91a4
Compare
innobead
requested changes
Nov 25, 2022
Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
…rocess Longhorn 3957 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
force-pushed
the
local-volume
branch
from
November 25, 2022 05:53
52c91a4
to
a082992
Compare
innobead
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longhorn 3957
Signed-off-by: Derek Su derek.su@suse.com