Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fast replica rebuilding by default #1592

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Enable fast replica rebuilding by default #1592

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02e3077
Move AutoCleanupSystemGeneratedSnapshot to category Snapshot
derekbit Dec 8, 2022
372194f
Enable fast replica rebuilding by default.
derekbit Dec 8, 2022
9e28749
Merge branch 'master' into issue-5023
innobead Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ var (
SettingDefinitionAutoCleanupSystemGeneratedSnapshot = SettingDefinition{
DisplayName: "Automatically Cleanup System Generated Snapshot",
Description: "This setting enables Longhorn to automatically cleanup the system generated snapshot before and after replica rebuilding.",
Category: SettingCategoryGeneral,
Category: SettingCategorySnapshot,
Type: SettingTypeBool,
Required: true,
ReadOnly: false,
Expand Down Expand Up @@ -948,7 +948,7 @@ var (
Type: SettingTypeString,
Required: true,
ReadOnly: false,
Default: string(longhorn.SnapshotDataIntegrityDisabled),
Default: string(longhorn.SnapshotDataIntegrityFastCheck),
Choices: []string{
string(longhorn.SnapshotDataIntegrityDisabled),
string(longhorn.SnapshotDataIntegrityEnabled),
Expand Down Expand Up @@ -992,12 +992,12 @@ var (

SettingDefinitionFastReplicaRebuildEnabled = SettingDefinition{
DisplayName: "Fast Replica Rebuild Enabled",
Description: "Enabling this setting will support the fast replica rebuild. The feature relies on the checksum of snapshot disk files, so the feature is setting the snapshot-data-integrity to **enable** or **fast-check** is a prerequisite.",
Description: "This setting enables the fast replica rebuilding feature. It relies on the checksums of snapshot disk files, so setting the snapshot-data-integrity to **enable** or **fast-check** is a prerequisite.",
Category: SettingCategoryGeneral,
Type: SettingTypeBool,
Required: true,
ReadOnly: false,
Default: "false",
Default: "true",
}
)

Expand Down