Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: if the snapshot is no longer in engine CR, don't block the removal process (backport #2074) #2077

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix bug: if the snapshot is no longer in engine CR, don't block the removal process (backport #2074) #2077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion controller/snapshot_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,8 @@ func (sc *SnapshotController) reconcile(snapshotName string) (err error) {
}
}()

if _, ok := snapshot.Status.Children["volume-head"]; ok && snapshot.Status.MarkRemoved {
_, snapshotExistInEngineCR := engine.Status.Snapshots[snapshot.Name]
if _, hasVolumeHeadChild := snapshot.Status.Children["volume-head"]; snapshotExistInEngineCR && hasVolumeHeadChild && snapshot.Status.MarkRemoved {
// This snapshot is the parent of volume-head, so it cannot be purged immediately.
// We do not want to keep the volume stuck in attached state.
return sc.handleAttachmentTicketDeletion(snapshot)
Expand Down