Record instance-manager name for a block disksin node.spec.diskStatus
#2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
changed the title
node.spec.diskStatusnode.spec.diskStatus
DamiaSan
approved these changes
Apr 29, 2024
instanceManagerName records the instance manager that manages the disk Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
A block-type disk can only be managed by a specific spdk_tgt within an instance manager. The commit is intended to record the name of the instance manager associated with that disk. On the other hand, for a filesystem-type disk, any instance manager can access it. Therefore, the recorded instance manager for a filesystem-type disk is always the default instance manager. Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8458
What this PR does / why we need it:
A block-type disk can only be managed by a specific spdk_tgt within an instance manager. The commit is intended to record the name of the instance manager associated with that disk.
On the other hand, for a filesystem-type disk, any instance manager can access it. Therefore, the recorded instance manager for a filesystem-type disk is always the default instance manager.
Special notes for your reviewer:
Additional documentation or context