[Draft] [DNM] Object Storage #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test skeleton for object endpoint creation/deletion tests for the manager / object endpoint controller Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Add first tests and fixtures for the object endpoint controller. There are two fixtures for testing the object endpoint controller: A storage class and an object endpoint. Although there is nothing special about the storage class, it is there as a fixture since it needs to be ensured a known storage class exists to be able to create an object endpoint. The object endpoint exists as fixture, because this makes creation and deletion easier, ensuring that even in the event of a failed test the object endpoint is cleaned up. In the object endpoint creation test, several assertions are made on the resources connected to the object endpoint to ensure creation was successful and the resulting object endpoint works as expected. In the object endpoint deletion test, an object endpoint is created, but then it is explicitly deleted. After that, several assertions are made to ensure no resources are left behind. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Cleanup code, fix linter warnings, add comments Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Test the controlled creation of a longhorn volume and PV Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Assert that when running the object endpoint's status will be updated with the endpoind address. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
- Adjust to ObjectStore CRD - Rename test suite for object store controller Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Fix cluster role and run all tests by default Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
|
This pull request is now in conflicts. Could you fix it @m-ildefons? 🙏 |
This was referenced Sep 19, 2023
- Change ObjectStore manifest and API calls to be namespaced, corresponding to the change in the CRD - Replace clear-text credentials in the ObjectStore manifest with a SecretRef and add a secret-fixture to let pytest handle the creation and deletion of the referenced secret Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Fix expected .status.state: Running -> running Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
- Fix naming of volume/PV - Fix secret creation - Fix s3 smoke test using the right credentials Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the object store controller in the Longhorn manager.
Related: longhorn/longhorn-manager#2136
Related: longhorn/longhorn#6640
LEP: longhorn/longhorn#5832