Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow use of existing private registry secret #2157

Closed
pulberg opened this issue Jan 6, 2021 · 4 comments
Closed

[FEATURE] Allow use of existing private registry secret #2157

pulberg opened this issue Jan 6, 2021 · 4 comments
Assignees
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/feature Feature request, new feature priority/2 Nice to implement or fix in this release (managed by PO)
Milestone

Comments

@pulberg
Copy link

pulberg commented Jan 6, 2021

Is your feature request related to a problem? Please describe.
When using a private registry, the installation requires the private registry user/pass to be entered and the name of the secret that will be created. I already have a cluster-wide (all namespaces) private registry secret, it doesn't make sense to have to create a new one for the Longhorn installation.

Describe the solution you'd like
The installation will let me enter the name of the existing private registry secret to use.

@joshimoo joshimoo added the kind/feature Feature request, new feature label Jan 6, 2021
@PhanLe1010
Copy link
Contributor

Sure! That makes sense.

@yasker yasker added this to the v1.1.1 milestone Jan 14, 2021
@yasker yasker added area/install-uninstall-upgrade Install, Uninstall or Upgrade related priority/2 Nice to implement or fix in this release (managed by PO) labels Jan 14, 2021
@yasker yasker modified the milestones: v1.1.1, v1.1.2 Jan 14, 2021
@innobead innobead changed the title [FEATURE] Allow use of existing private registry secret. [FEATURE] Allow use of existing private registry secret Apr 26, 2021
@innobead innobead added require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation labels Apr 29, 2021
@innobead innobead modified the milestones: v1.1.2, v1.2.0 Apr 29, 2021
@innobead innobead modified the milestones: v1.2.0, v1.3.0 Aug 2, 2021
wilson1999112 referenced this issue in wilson1999112/longhorn Feb 27, 2022
Signed-off-by: wilson1999112 <wilson1999112@gmail.com>
@innobead innobead removed require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation labels Mar 18, 2022
@kaxing kaxing self-assigned this Apr 6, 2022
@kaxing
Copy link

kaxing commented Apr 6, 2022

This was validated within v1.2.0 release test cycle: #2432 (comment)

But the current function says it will auto-generate new secret rather giving an option as requested in the original description. cc @innobead
image

@innobead
Copy link
Member

innobead commented Apr 6, 2022

This was validated within v1.2.0 release test cycle: #2432 (comment)

But the current function says it will auto-generate new secret rather giving an option as requested in the original description. cc @innobead

image

@kaxing u should verify on 1.3.0 instead of 1.2.x. I would suggest to wait to test until we have rc1 chart.

@innobead innobead assigned yangchiu and unassigned kaxing Apr 28, 2022
@yangchiu
Copy link
Member

verified passed on master-head by importing repo: longhorn/longhorn/chart master-head into rancher (using https://github.com/yangchiu/rancher-charts/tree/longhorn-v1.3.0) and try to install the imported latest longhorn.

#3954 is needed since there's some incorrect indent and missing double-quote on the original master-head cause the questions unable to be displayed while the installation.

with #3954, the "using existing private registry secret" options displays and functions as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install-uninstall-upgrade Install, Uninstall or Upgrade related kind/feature Feature request, new feature priority/2 Nice to implement or fix in this release (managed by PO)
Projects
Archived in project
Status: Closed
Development

No branches or pull requests

10 participants