-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow use of existing private registry secret #2157
Comments
Sure! That makes sense. |
Signed-off-by: wilson1999112 <wilson1999112@gmail.com>
This was validated within v1.2.0 release test cycle: #2432 (comment) But the current function says it will auto-generate new secret rather giving an option as requested in the original description. cc @innobead |
@kaxing u should verify on 1.3.0 instead of 1.2.x. I would suggest to wait to test until we have rc1 chart. |
verified passed on master-head by importing repo: longhorn/longhorn/chart master-head into rancher (using https://github.com/yangchiu/rancher-charts/tree/longhorn-v1.3.0) and try to install the imported latest longhorn. #3954 is needed since there's some incorrect indent and missing double-quote on the original master-head cause the questions unable to be displayed while the installation. with #3954, the "using existing private registry secret" options displays and functions as expected. |
Is your feature request related to a problem? Please describe.
When using a private registry, the installation requires the private registry user/pass to be entered and the name of the secret that will be created. I already have a cluster-wide (all namespaces) private registry secret, it doesn't make sense to have to create a new one for the Longhorn installation.
Describe the solution you'd like
The installation will let me enter the name of the existing private registry secret to use.
The text was updated successfully, but these errors were encountered: