-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] After adding taint to a node, volume cannot be attached to any other node #2475
Comments
Proposal: We need to differentiate 2 cases when the Instance Manager get into the error state:
|
This is not a regression and it's a day 1 issue. @shuo-wu "There is no similar issue with the node down case. We can add the similar logic for this case:" |
Pre Ready-For-Testing Checklist
|
Validation: PASSED |
Describe the bug
Volume stuck in attaching after setting taint for a one of it replicas' node
To Reproduce
f:b=NoExecute
for a nodeExpected behavior
Longhorn should skip the replica on the tainted node and finish attaching volume
Environment:
Additional context
The replica controller always set the state of the replica: status.CurrentState = types.InstanceStateStopped when the corresponding instance manager is in error state. On the other hand, the volume controller insists on waiting until all replicas to be in running state before finishing attaching the volume
The text was updated successfully, but these errors were encountered: