Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Kubernetes snapshot support (csi-snapshotter) #304

Closed
yasker opened this issue Sep 28, 2018 · 10 comments
Closed

[FEATURE] Kubernetes snapshot support (csi-snapshotter) #304

yasker opened this issue Sep 28, 2018 · 10 comments
Assignees
Labels
area/kubernetes Kubernetes related like K8s version compatibility component/longhorn-manager Longhorn manager (control plane) highlight Important feature/issue to highlight kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) release/note Note for installation, upgrade and highlighted issues require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/lep Require adding/updating enhancement proposal
Milestone

Comments

@yasker
Copy link
Member

yasker commented Sep 28, 2018

In Kubernetes 1.12, the snapshot support will be added. We will evaluate the feature and if it goes well, we will add the support for it.

The doc is at:
https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-snapshot.md

The external snapshotter:
https://github.com/kubernetes-csi/external-snapshotter

@yasker yasker added kind/feature Feature request, new feature component/longhorn-manager Longhorn manager (control plane) area/driver labels Sep 28, 2018
@yasker yasker added this to the v0.4.0 milestone Sep 28, 2018
@yasker yasker modified the milestones: v0.4.0, v0.5.0 Feb 8, 2019
@yasker yasker modified the milestones: v0.5.0, v0.6.0 Apr 3, 2019
@yasker yasker modified the milestones: v0.6.0, v0.7.0 Jun 10, 2019
@yasker yasker added the area/kubernetes Kubernetes related like K8s version compatibility label Sep 21, 2019
@yasker yasker modified the milestones: v0.7.0, v0.7.1 Sep 23, 2019
@yasker yasker modified the milestones: v0.7.1, Planning Oct 3, 2019
@yasker yasker modified the milestones: Planning, v0.8.0 Dec 3, 2019
@yasker yasker added the highlight Important feature/issue to highlight label Dec 6, 2019
@yasker yasker modified the milestones: v0.8.1, Planning Jan 2, 2020
@yasker yasker modified the milestones: Planning, v1.1.0 Jun 12, 2020
@yasker yasker added priority/0 Must be fixed in this release (managed by PO) require/lep Require adding/updating enhancement proposal labels Jun 12, 2020
@lomori
Copy link

lomori commented Sep 8, 2020

Any estimates for when the CSI Volume Snapshot is going to be available?

@joshimoo
Copy link
Contributor

joshimoo commented Sep 8, 2020

@lomori csi snapshot support is going to be included in the longhorn 1.1 release which is targeting early November.
After this issue is closed, it will be available in the master branch and can be used for testing.

joshimoo added a commit to joshimoo/longhorn that referenced this issue Sep 9, 2020
Longhorn longhorn#304

Signed-off-by: Joshua Moody <joshua.moody@rancher.com>
joshimoo added a commit to joshimoo/longhorn that referenced this issue Sep 9, 2020
Longhorn longhorn#304

Signed-off-by: Joshua Moody <joshua.moody@rancher.com>
yasker pushed a commit that referenced this issue Sep 9, 2020
Longhorn #304

Signed-off-by: Joshua Moody <joshua.moody@rancher.com>
@joshimoo
Copy link
Contributor

Document outlining the kubernetes snapshot support changes between the alpha and beta csi snapshot support.
https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/177-volume-snapshot#controller-split

@khushboo-rancher
Copy link
Contributor

Verified on longhorn Master - 09/14/2020

Validation - Pass

Executed the test cases from https://rancher.atlassian.net/wiki/spaces/LON/pages/735379688/CSI+Snapshot+Support

Once #1788 is closed, we are good to close this feature.

@khushboo-rancher khushboo-rancher added the require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated label Sep 23, 2020
@meldafrawi meldafrawi self-assigned this Sep 29, 2020
@joshimoo
Copy link
Contributor

joshimoo commented Oct 7, 2020

@khushboo-rancher is this issue good to close?

@khushboo-rancher
Copy link
Contributor

Functionality has been validated manually and right now the implementation of integration tests for this feature is in progress.
We can close this issue and create one for the integration test implementation if we want.

@joshimoo
Copy link
Contributor

joshimoo commented Oct 7, 2020

@khushboo-rancher thanks no problem you can keep it open then, was just following up :)

@yasker
Copy link
Member Author

yasker commented Dec 7, 2020

It's unlikely we have time for writing the automation test for this issue in v1.1.0. Let's do a regression test and then punt it to v1.1.1 release.

@PhanLe1010
Copy link
Contributor

Revalidated manually: Pass

@khushboo-rancher khushboo-rancher modified the milestones: v1.1.0, v1.1.1 Dec 15, 2020
@innobead innobead changed the title Kubernetes snapshot support (csi-snapshotter) [FEATURE] Kubernetes snapshot support (csi-snapshotter) Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes related like K8s version compatibility component/longhorn-manager Longhorn manager (control plane) highlight Important feature/issue to highlight kind/feature Feature request, new feature priority/0 Must be fixed in this release (managed by PO) release/note Note for installation, upgrade and highlighted issues require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/lep Require adding/updating enhancement proposal
Projects
None yet
Development

No branches or pull requests

8 participants