Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add prep work for fixing the corrupted filesystem using fsck in KB #4440

Closed
derekbit opened this issue Aug 17, 2022 · 3 comments
Assignees
Labels
kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@derekbit
Copy link
Member

derekbit commented Aug 17, 2022

Is your improvement request related to a feature? Please describe

fsck usually needs to be run to fix a corrupted filesystem. It is possible, however, that the incorrect fsck fix might cause serious data loss and corruption.
To mitigate the risk, a snapshot of the corrupted filesystem should be taken before any fix attempts are made. In case of an accident, the user can recover the volume. We can suggest the prep work in the KB.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

https://serverfault.com/questions/786648/when-is-fsck-dangerous
https://docs.portworx.com/reference/cli/volume-check/

@derekbit derekbit added the kind/improvement Request for improvement of existing function label Aug 17, 2022
@innobead innobead added this to the v1.4.0 milestone Aug 18, 2022
@innobead innobead added the priority/0 Must be fixed in this release (managed by PO) label Aug 18, 2022
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Aug 22, 2022

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Does the PR include the explanation for the fix or the feature?

  • Which areas/issues this PR might have potential impacts on?
    Area: filesystem corruption
    Issues

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

#4440

@khushboo-rancher
Copy link
Contributor

@derekbit Can you please help with the reproduction steps, so that we can test this?

@innobead
Copy link
Member

@khushboo-rancher it's just extending the existing KB to make it clear for users about what they should pay attention to when doing fsck on a volume, so there is no needs to prepare any reproduce steps here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

4 participants