Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Enable fast replica rebuilding by default #5023

Closed
1 task
derekbit opened this issue Dec 8, 2022 · 2 comments
Closed
1 task

[IMPROVEMENT] Enable fast replica rebuilding by default #5023

derekbit opened this issue Dec 8, 2022 · 2 comments
Assignees
@derekbit @roger-ryao
Labels
area/performance System, volume performance area/replica Volume replica where data is placed area/setting Global setting or volume setting component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO)
Milestone
v1.4.0

Comments

@derekbit
Copy link
Member

derekbit commented Dec 8, 2022

What's the task? Please describe

Enable fast replica rebuilding by default.

  • Snapshot Data Integrity: fast-check
  • Immediate Snapshot Data Integrity Check After Creating a Snapshot: false
  • Fast Replica Rebuild Enabled: true

Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

  • item 1

Additional context

Add any other context or screenshots about the task request here.
@derekbit derekbit added the kind/task General task request to fulfill another primary request label Dec 8, 2022
@derekbit derekbit self-assigned this Dec 8, 2022
@innobead innobead added this to the v1.4.0 milestone Dec 8, 2022
@innobead innobead added area/replica Volume replica where data is placed area/performance System, volume performance area/setting Global setting or volume setting labels Dec 8, 2022
@derekbit derekbit mentioned this issue Dec 8, 2022
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 8, 2022 •
edited by derekbit

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#1592

  • Which areas/issues this PR might have potential impacts on?
    Area: snapshot checksum, replica rebuilding
    Issues

@derekbit derekbit mentioned this issue Dec 8, 2022
Merged
@innobead innobead changed the title [TASK] Enable fast replica rebuilding by default [IMPROVEMENT] Enable fast replica rebuilding by default Dec 9, 2022
@innobead innobead added kind/improvement Request for improvement of existing function component/longhorn-manager Longhorn manager (control plane) priority/0 Must be fixed in this release (managed by PO) and removed kind/task General task request to fulfill another primary request labels Dec 9, 2022
@roger-ryao
Copy link

Verified on master-head 20221209

  • longhorn master-head (f30875a)
  • longhorn-manager master-head (301e1e0)

The test steps

Ref #5023 (To Reproduce)

Result Passed
Screenshot_20221209_154444

Screenshot_20221209_154514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@roger-ryao roger-ryao

Labels
area/performance System, volume performance area/replica Volume replica where data is placed area/setting Global setting or volume setting component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
4 participants
@innobead @derekbit @longhorn-io-github-bot @roger-ryao