Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] System restore job name should be Longhorn prefixed #5057

Closed
c3y1huang opened this issue Dec 14, 2022 · 2 comments
Closed

[IMPROVEMENT] System restore job name should be Longhorn prefixed #5057

c3y1huang opened this issue Dec 14, 2022 · 2 comments
Assignees
Labels
area/system-backup-restore Longhorn system backup restore component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function
Milestone

Comments

@c3y1huang
Copy link
Contributor

c3y1huang commented Dec 14, 2022

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

Longhorn system-restore job name is the SystemRestore name and the pod name is in format <system-restore-name>-<random-uuid>. This makes it hard to identify that they are from the Longhorn system restore job.

Describe the solution you'd like

Have a longhorn-system-rollout prefix for the system restore created job and pod.

Describe alternatives you've considered

None

Additional context

None

@c3y1huang c3y1huang added kind/improvement Request for improvement of existing function area/system-backup-restore Longhorn system backup restore labels Dec 14, 2022
@c3y1huang c3y1huang self-assigned this Dec 14, 2022
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 14, 2022

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at:

  • Which areas/issues this PR might have potential impacts on?
    Area system-backup/restore
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@c3y1huang c3y1huang added this to the v1.4.0 milestone Dec 14, 2022
@innobead innobead added the component/longhorn-manager Longhorn manager (control plane) label Dec 14, 2022
@innobead innobead changed the title [IMPROVEMENT] system restore job name should be Longhorn prefixed [IMPROVEMENT] System restore job name should be Longhorn prefixed Dec 15, 2022
@khushboo-rancher
Copy link
Contributor

Validation - Pass

Verified with v1.4.x-head

Screenshot 2022-12-15 at 3 04 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system-backup-restore Longhorn system backup restore component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function
Projects
None yet
Development

No branches or pull requests

5 participants