[IMPROVEMENT] Inconsistent name convention across volume backup restore and system backup restore

[khushboo-rancher]

Is your improvement request related to a feature? Please describe (👍 if you like this request)

User can restore a volume backup with restore-1volume-1backup-2 but can't restore system backup with the same name.
We can follow same naming convention across the product.

[c3y1huang]

Hi @khushboo-rancher , I am not able to reproduce this.

I've also asked @chriscchien to try and seems not reproducible.

Can you provide the support bundle?

[khushboo-rancher]

I have the support bundle but I've done lots of other operations on the cluster.

supportbundle_53cae9b1-ec77-40ba-aa16-a9171b760e3e_2022-12-15T02-57-59Z.zip

Time around - 2022-12-14 08:00 AM in UTC

[c3y1huang]

I can't tell from the support bundle.

We do not set a naming convention for SystemBackup/Restore. For now, I am not able to reproduce.

[khushboo-rancher]

I encountered this again with v1.4.0-rc-2

[longhorn-manager-6vgg7 longhorn-manager] time="2022-12-22T20:20:31Z" level=warning msg="HTTP handling error failed to create SystemRestore restore-1`: SystemRestore.longhorn.io \"restore-1`\" is invalid: metadata.name: Invalid value: \"restore-1`\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')"

[c3y1huang]

@khushboo-rancher , possibly a typo in the name? It seems to include a backtick (`).

And after looking at the issue description, it seems restore-1volume-1backup-2 is prefixed with a space.

[weizhe0422]

Following the steps below to test on master-head and 1.4.x-head, I can reproduce the error message mentioned in this comment because there is a space in the string prefix.

1. Install Longhorn and set up backup target path
2. Create or restore a system backup with name restore-1volume-1backup-2
   
   

[innobead]

Ok, this is inconsistent at UI. When restoring a volume, UI will do the trim to remove the prefix empty characters, so the payload sent is actually w/o an invalid empty character anymore.

https://github.com/longhorn/longhorn-ui/blob/20dbdf331fd0efe299523341058a7c90f62d6f1f/src/routes/backup/RestoreBackup.js#L46-L48

For the backend, we don't have any pre-cleanup for users, so if users create SystemRestore CR directly, they will still encounter this kind of issue. Personally, I think we don't need to do any specific behavior for that because that kind of error can teach users how to use Longhorn or K8s.

So, this is more about the Longhorn UI experience.

[roger-ryao]

Verified on master-head 20221227

• longhorn master-head (62998ad)
• longhorn-ui master-head (f9ed1f7)

Verified on v1.4.x-head 20221227

• longhorn v1.4.x-head (c32192c)
• longhorn-ui v1.4.x-head (3109b51)

The test steps

1. Create the system backup with the prefix empty characters name
2. Restore System backup with the prefix empty characters name
   e.g. restore-1volume-1backup-2

Result Passed