-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark nodes with/without certain label as disabled/enabled by default #583
Comments
|
Per discussion with @yasker, it seems like |
@ttpcodes We want to use annotations in this case instead of labels since we didn't expect users to frequently search for the annotation. And it's a one-time operation, happens only when adding the node. |
I would strongly encourage to follow @ttpcodes suggestion to use node labels and not node annotations to determine if a node is suitable for a longhorn disk or not. The common way in Kubernetes is to specify node capabilities using labels, not annotations. Annotations is usually describing arbitrary node metadata, not node capabilities. |
@paalkr Fair enough. Labels are more likely used for classification in Kubernetes. Though what if the user removed a label from the node? I don't think we can remove the default disk automatically due to there can still be replica data on it. |
Will that be any different then if a user removed an annotation? Never the less, |
@paalkr Yeah, I was talking about another thing, not related to use label or annotation. We can use the label. How about this: Setting option:
|
Sounds reasonable. I assume that the ability to define a custom default data path (#582) will apply in both scenarios? |
So how are these settings specified during longhorn system deployment? In a configmap? |
Excellent, thanks! It makes perfect sense to be able to define settings related to default data path (#582) and node labels to automatically enable/disable scheduling, during the initial deployment. |
Validation FAILED. Steps to test:
I expected that after the nodes gets added to the cluster, only the node labeled will be |
@ttpcodes ^^ I think we haven't updated the label in the setting usage yet. |
@meldafrawi Fix merged. |
@meldafrawi what's your reproduce step? |
Steps to test:
|
@meldafrawi The instruction for setting should have changed. Take a look at the PR. |
Validation PASSED. Steps to test:
|
Ref: #574
Only some of the nodes in my cluster has disks attached that is intended for Longhorn. So I would like to store Longhorn data only on nodes that has a specific label. All other nodes should by default be marked as disabled.
The text was updated successfully, but these errors were encountered: