Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Button "Take Snapshot" and "Create Backup" grayed out. #6841

Closed
chriscchien opened this issue Oct 4, 2023 · 5 comments · Fixed by longhorn/longhorn-ui#654
Closed
Assignees
Labels
area/ui UI related like UI or CLI kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO) require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Milestone

Comments

@chriscchien
Copy link
Contributor

Describe the bug (🐛 if you encounter this issue)

In longhorn v1.6.0-dev UI, on the volume detail page, button "Take Snapshot" and "Create Backup" grayed out even when the volume is attached and backup target is setup correctly. (Create backup through API is still working(test result))

image

To Reproduce

  1. Deploy longhorn v1.6.0-dev
  2. Setup backup target
  3. Create volume and attach to a node
  4. Navigate to volume detail page
  5. Button "Take Snapshot" and "Create Backup" grayed out.

Expected behavior

Button "Take Snapshot" should in enable state when volume attached
Button "Create Backup" should in enable state when volume attached and when backup target setup correcty

Support bundle for troubleshooting

N/A

Environment

  • Longhorn version: v1.6.0-dev
  • Installation method (e.g. Rancher Catalog App/Helm/Kubectl): kubectl
  • Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s

Additional context

Did not see in v1.5 dev

@chriscchien chriscchien added kind/bug area/ui UI related like UI or CLI severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade) kind/regression Regression which has worked before require/qa-review-coverage Require QA to review coverage require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Oct 4, 2023
@chriscchien chriscchien added this to the v1.6.0 milestone Oct 4, 2023
@chriscchien chriscchien removed the require/backport Require backport. Only used when the specific versions to backport have not been definied. label Oct 4, 2023
@PhanLe1010
Copy link
Contributor

PhanLe1010 commented Oct 10, 2023

Additional report:

Upgrading engine image is also grayed out even though there is a qualified engine image
Screenshot from 2023-10-09 21-54-41

Upgrading using the API directly still work:
Screenshot from 2023-10-09 21-55-04

@james-munson
Copy link
Contributor

In addition, the option for "upgrade engine" is absent from the right-hand dropdown menu on the volume itself.

@james-munson
Copy link
Contributor

On the other hand, in the view of engine images, the "delete" option is not grayed out, even for an image that cannot be deleted because it is the default image or is actively in use by some volume.

@james-munson
Copy link
Contributor

Looking at the conditions for when snapshot create is disabled, I wonder whether something has changed to fool the logic that tests for an engine upgrade in progress, so it always appears to be true.

@ejweber
Copy link
Contributor

ejweber commented Oct 11, 2023

I did not do any testing on this or follow through on it at all, however, when we were discussing this offline it jogged my memory and I think this might be a good place to start.

Among other conditions, we grey out the Take Snapshot button if volume.currentImage != volume.engineImage.

https://github.com/longhorn/longhorn-ui/blob/1b2b2db0ad302fd50dc2aec75f16438577a4bd6e/src/routes/volume/helper/index.js#L566-L568

However, we deprecated the engineImage field in https://github.com/longhorn/longhorn-manager/pull/2139/files.

There is already a UI issue tracking this at #6685 with an additional comment about engine upgrades not working (similar to @PhanLe1010's above).

Probably a proper implementation of #6685 will resolve this bug.

@innobead innobead added the priority/0 Must be fixed in this release (managed by PO) label Oct 12, 2023
votdev added a commit to votdev/longhorn-ui that referenced this issue Oct 25, 2023
…h spec.image

Fixes: longhorn/longhorn#6685
Fixes: longhorn/longhorn#6841

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev added a commit to votdev/longhorn-ui that referenced this issue Oct 25, 2023
…h spec.image

Fixes: longhorn/longhorn#6685
Fixes: longhorn/longhorn#6841

Signed-off-by: Volker Theile <vtheile@suse.com>
m-ildefons pushed a commit to m-ildefons/longhorn-ui that referenced this issue Nov 6, 2023
…h spec.image

Fixes: longhorn/longhorn#6685
Fixes: longhorn/longhorn#6841

Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui UI related like UI or CLI kind/bug kind/regression Regression which has worked before priority/0 Must be fixed in this release (managed by PO) require/qa-review-coverage Require QA to review coverage severity/1 Function broken (a critical incident with very high impact (ex: data corruption, failed upgrade)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants