Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Add global setting for enable v1 or v2 volume support #7095

Closed
derekbit opened this issue Nov 14, 2023 · 2 comments
Closed

[IMPROVEMENT] Add global setting for enable v1 or v2 volume support #7095

derekbit opened this issue Nov 14, 2023 · 2 comments
Assignees
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation
Milestone

Comments

@derekbit
Copy link
Member

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

Add global setting for enable v1 or v2 volume support.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@derekbit derekbit added priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation kind/improvement Request for improvement of existing function area/v2-data-engine v2 data engine (SPDK) require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Nov 14, 2023
@derekbit derekbit added this to the v1.6.0 milestone Nov 14, 2023
@derekbit derekbit self-assigned this Nov 14, 2023
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Dec 19, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  • v1-data-engine

    1. Create a LH cluster
    2. Create a v1 volume and attacg it
    3. Set v1-data-engine setting to false. The request should be rejected.
    4. Detach the volume. Then, set v1-data-engine setting to true. The request should be accepted.
    5. Try to attach the volume. The attachment should not work.
    6. Set v1-data-engine setting to true. Then, attach the volume again, it should work.
  • v2-data-engine

    • Similar steps as v1-data-engine
  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

#7403

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2386

  • Which areas/issues this PR might have potential impacts on?
    Area: v1 and v2 volumes, instance-managers
    Issues

@yangchiu
Copy link
Member

Verified passed on master-head (longhorn-manager be08850) following the test steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2-data-engine v2 data engine (SPDK) kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation
Projects
None yet
Development

No branches or pull requests

3 participants