Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 #7459

Closed
mantissahz opened this issue Dec 26, 2023 · 3 comments
Assignees
Labels
area/chart Helm chart related backport/1.4.5 kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Milestone

Comments

@mantissahz
Copy link
Contributor

Describe the bug (馃悰 if you encounter this issue)

The wrong template in the default-setting.yaml file such as https://github.com/longhorn/longhorn/blob/v1.5.x/chart/templates/default-setting.yaml#L49-L57.
That will make the field data of the ConfigMap longhorn-default-setting get the wrong data format.
Or get the unexpected result by running the script longhorn/scripts/generate-longhorn-yaml.sh.

Expected behavior

Generate the correct data from longhorn/chart/templates/default-setting.yaml file

Additional context

@mantissahz mantissahz added kind/bug require/qa-review-coverage Require QA to review coverage require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Dec 26, 2023
@innobead innobead added the area/chart Helm chart related label Dec 26, 2023
@innobead
Copy link
Member

@mantissahz self assign and assign to the milestone directly next time.

@innobead innobead modified the milestones: v1.6.0, v1.5.4 Dec 26, 2023
@mantissahz mantissahz changed the title [BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 [v1.5.3][BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 Dec 26, 2023
@mantissahz mantissahz changed the title [v1.5.3][BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 [v1.5.4][BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 Dec 26, 2023
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 24, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Customize some values of the defaultSettings in chart/values.yaml
  2. Install Longhorn with chart/values.yaml by Helm
  3. Install successfully and default settings as expected.
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:
    charts: fix the default-setting cm format issue聽#7767

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@innobead innobead changed the title [v1.5.4][BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 [BUG] The wrong template in default-setting.yaml of the Longhorn chart in v1.5 and v1.4 Jan 24, 2024
@roger-ryao
Copy link

Verified on v1.5.4-rc1 20240206

The test steps
#7459 (comment)

Result Passed

  1. Install successfully and default settings as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart Helm chart related backport/1.4.5 kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Projects
None yet
Development

No branches or pull requests

5 participants