Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT][UI] Validate volume creation according to the enabled data engines #7505

Closed
derekbit opened this issue Jan 1, 2024 · 2 comments
Closed

[IMPROVEMENT][UI] Validate volume creation according to the enabled data engines #7505

derekbit opened this issue Jan 1, 2024 · 2 comments
Assignees
@derekbit @chriscchien
Labels
area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation
Milestone
v1.6.0

Comments

@derekbit
Copy link
Member

derekbit commented Jan 1, 2024

Is your improvement request related to a feature? Please describe (馃憤 if you like this request)

The current validation in UI codes only handles v2 volumes. Longhorn starts supporting v1-data-engine setting, so the validation of v1 volume is required as well.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@derekbit derekbit added area/ui UI related like UI or CLI require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/doc Require updating the longhorn.io documentation kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. labels Jan 1, 2024
@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
@derekbit derekbit added this to the v1.6.0 milestone Jan 1, 2024
@derekbit derekbit mentioned this issue Jan 1, 2024
Merged
@derekbit derekbit self-assigned this Jan 1, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 1, 2024 •
edited by derekbit

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Disable v2-data-engine
  2. Create a volume with v2 data engine on the UI
  3. A corresponding error message should be printed.

  • Does the PR include the explanation for the fix or the feature?

  • Which areas/issues this PR might have potential impacts on?
    Area: volume creation
    Issues

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

longhorn/longhorn-ui#674

@chriscchien chriscchien self-assigned this Jan 2, 2024
@chriscchien
Copy link
Contributor

Verified pass on longhorn master(longhorn-ui be2408) with steps

Can see prompt after try create v2 volume from UI if v2 data engine not enabled.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@chriscchien chriscchien

Labels
area/ui UI related like UI or CLI kind/improvement Request for improvement of existing function require/auto-e2e-test Require adding/updating auto e2e test cases if they can be automated require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@derekbit @longhorn-io-github-bot @chriscchien