Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add Snapshot Maximum Count to the Settings #7906

Closed
yardenshoham opened this issue Feb 9, 2024 · 3 comments
Closed

[BUG] Add Snapshot Maximum Count to the Settings #7906

yardenshoham opened this issue Feb 9, 2024 · 3 comments
Assignees
Labels
backport/1.6.1 kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Milestone

Comments

@yardenshoham
Copy link
Contributor

Describe the bug

This setting is missing

Additional context

#7896
#7894

@yardenshoham yardenshoham added kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage labels Feb 9, 2024
@innobead innobead added this to the v1.7.0 milestone Feb 20, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Feb 20, 2024

Pre Ready-For-Testing Checklist

@innobead
Copy link
Member

@FrankYang0529 Please help drive this to ready for testing. Thanks.

@roger-ryao
Copy link

Verified on master-head 20240312

The test steps

#7906 (comment)

Result Passed

  • Install LH via helm chart without error.
  • require/chart : Installed Longhorn using Helm chart and modified snapshotMaxCount to 10, and it took effect.
    Screenshot_20240312_121304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.6.1 kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Projects
Development

No branches or pull requests

5 participants