Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.5.5][BUG] persistence.removeSnapshotsDuringFilesystemTrim Helm variable is unreferenced #7951

Closed
github-actions bot opened this issue Feb 16, 2024 · 2 comments
Closed

[BACKPORT][v1.5.5][BUG] persistence.removeSnapshotsDuringFilesystemTrim Helm variable is unreferenced #7951

github-actions bot opened this issue Feb 16, 2024 · 2 comments
Assignees
@ejweber @roger-ryao
Labels
kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Milestone
v1.5.5

Comments

@github-actions
Copy link

backport #7909
@github-actions github-actions bot added kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage labels Feb 16, 2024
@github-actions github-actions bot added this to the v1.5.5 milestone Feb 16, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 2, 2024 •
edited by ejweber

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?

Default case:

  1. Do not set any values.
  2. Helm install/upgrade.
  3. Check the longhorn StorageClass for unmapMarkSnapChainRemoved: ignored.

Non-default case:

  1. Set the value of persistence.removeSnapshotsDuringFilesystemTrim to enabled in `values.yaml.
  2. Helm install/upgrade.
  3. Check the longhorn StorageClass for unmapMarkSnapChainRemoved: enabled.

@roger-ryao roger-ryao self-assigned this Apr 8, 2024
@roger-ryao
Copy link

Verified on v1.5.x-head 20240408

The test steps

#7951 (comment)

Result Passed

Default case ： Check the longhorn StorageClass for unmapMarkSnapChainRemoved: ignored.

  • 1. v1.5.x-head
  • 2. v1.5.4 upgrade to v1.5.x-head

Non-default case : Check the longhorn StorageClass for unmapMarkSnapChainRemoved: enabled.

  • 1. v1.5.x-head
  • 2. v1.5.4 upgrade to v1.5.x-head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejweber ejweber

@roger-ryao roger-ryao

Labels
kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Projects
None yet
Milestone
v1.5.5
Development

No branches or pull requests
3 participants
@ejweber @longhorn-io-github-bot @roger-ryao