Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.5.5][REFACTOR] move mount point check function to common lib #8125

Closed
github-actions bot opened this issue Mar 7, 2024 · 2 comments
Closed
Assignees
Labels
component/longhorn-instance-manager Longhorn instance manager (interface between control and data plane) component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) kind/backport Backport request kind/refactoring Request for refactoring (code) priority/0 Must be fixed in this release (managed by PO)
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Mar 7, 2024

backport #7394

@github-actions github-actions bot added component/longhorn-instance-manager Longhorn instance manager (interface between control and data plane) component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) kind/backport Backport request kind/refactoring Request for refactoring (code) priority/0 Must be fixed in this release (managed by PO) labels Mar 7, 2024
@github-actions github-actions bot added this to the v1.5.5 milestone Mar 7, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Mar 8, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. Create single node cluster curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION=v1.28.5+k3s1 sh -s - --write-kubeconfig-mode 644
  2. Deploy Longhorn master-head
  3. Create a single replica volume, attach to node with deployment, record the PVC name
  4. Find the PVC mount location mount | grep "/dev/longhorn/${VOLUME_NAME}"
    /host/var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/${VOLUME_NAME_HASH}/globalmount
  5. Remount PVC to read only by below command (remember the path ends with "globalmount" )
mount -o remount,ro /host/var/lib/kubelet/plugins/kubernetes.io/csi/driver.longhorn.io/${VOLUME_NAME_HASH}/globalmount
  1. The engine condition should back to FaileSystemReadOnly: false and the IO works in the workload

PRs:
longhorn/go-common-libs#19
longhorn/longhorn-instance-manager#428
longhorn/longhorn-share-manager#152

@roger-ryao
Copy link

Verified on v1.5.x-head 20240327

The test steps

#8125 (comment)

Result Passed

The volume's engine condition would change back to FailedSystemReadOnly: false, and the IO would work in the workload.

> k -n longhorn-system describe engine vol-0-e-0 |grep -H3 'FilesystemReadOnly'
(standard input)-    Message:               
(standard input)-    Reason:                
(standard input)-    Status:                False
(standard input):    Type:                  FilesystemReadOnly
(standard input)-  Current Image:           longhornio/longhorn-engine:v1.5.x-head
(standard input)-  Current Replica Address Map:
(standard input)-    vol-0-r-b1b49dcf:        10.42.0.21:10000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/longhorn-instance-manager Longhorn instance manager (interface between control and data plane) component/longhorn-share-manager Longhorn share manager (control plane for NFS server, RWX) kind/backport Backport request kind/refactoring Request for refactoring (code) priority/0 Must be fixed in this release (managed by PO)
Projects
None yet
Development

No branches or pull requests

3 participants