Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.5.5][BUG] Backup marked as "completed" cannot be restored, gzip: invalid header #8378

Closed
github-actions bot opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
area/volume-backup-restore Volume backup restore kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Milestone

Comments

@github-actions
Copy link

backport #7687

@github-actions github-actions bot added area/volume-backup-restore Volume backup restore kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage labels Apr 17, 2024
@github-actions github-actions bot added this to the v1.5.5 milestone Apr 17, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 17, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

We are still investigating the root cause of the issue.
The PRs improve the resilience in the decompression path.

  • Test case 1

    1. Create a volume in LH v1.4.x, write data and take backup multiple times
    2. Update to v1.5.x, restore the backups. The restoration should succeed.
  • Test case 2

    1. Create a volume in LH v1.5.x, write data and take backup multiple times
    2. Restore the backups. The restoration should succeed.
  • Test case 3 (cc @ChanYiLin )

    1. Back up backing images and restore it
  • Test case 4

    1. The test cases in e2e related to backup/restore should pass
  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/backupstore#167
longhorn/longhorn-engine#1076

  • Which areas/issues this PR might have potential impacts on?
    Area: backup and restore
    Issues

@derekbit derekbit self-assigned this Apr 17, 2024
@chriscchien
Copy link
Contributor

Verifed pass on longhorn v1.5.x (longhorn-engine 2f9588) with test cases

Test case 1 - Pass
Test case 2 - Pass
Test case 3 - N/A, v1.5.x did not support backup backing image
Test case 4 - restore and backup test cases did not see outstanging issue

@chriscchien chriscchien self-assigned this Apr 17, 2024
@derekbit
Copy link
Member

Thank you @chriscchien
cc @innobead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/volume-backup-restore Volume backup restore kind/backport Backport request kind/bug require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Projects
None yet
Development

No branches or pull requests

3 participants