New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: change to use GitHub actions #102
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: PoAn Yang <yangpoan@gmail.com>
jobs: | ||
build: | ||
name: Build binaries | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, do we have other options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @derekbit, it looks like test failed because I added error check to avoid lint issue. Can we assert sparse-tools/sparse/test/client_test.go Lines 255 to 256 in 813ac9e
|
It looks like server returns |
Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Hi @derekbit, I tried to remove error check, but there still has data race condition. May you take a look when you have time? Thank you. https://github.com/longhorn/sparse-tools/actions/runs/8888699426/job/24405917283?pr=102 |
Which issue(s) this PR fixes:
longhorn/longhorn#8039
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context