Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Azure Blob Storage backupstore support #690

Merged
merged 9 commits into from
May 18, 2023

Conversation

mantissahz
Copy link
Contributor

Set a remote backup target.

Ref: longhorn/longhorn#1309

@mantissahz mantissahz self-assigned this Apr 18, 2023
innobead
innobead previously approved these changes Apr 18, 2023
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if need to have AZURE_ENDPOINT and resolve the comment before merging this PR.

@innobead
Copy link
Member

@mantissahz Please refer to the AWS S3 setup to describe the setup more clearly like that.

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments still need to resolve.

@innobead
Copy link
Member

As discussed, need to update the implementation to clarify the difference between blob endpoint and suffix, so this doc also needs to update accordingly.

Add Azure Blob Storage support and how do users to setup a backup
target for an Azure Blob Storage server.

Ref: 1309

Signed-off-by: James Lu <james.lu@suse.com>
@mantissahz mantissahz changed the title Add Azure Blob Storage backupstore doc: Azure Blob Storage backupstore support May 18, 2023
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some grammar. In general, LGTM.

Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some grammar. In general, LGTM.

@innobead innobead merged commit 023c922 into longhorn:master May 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants