Explain trim behavior while rebuilding and clean up doc #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuo-wu
previously approved these changes
Feb 7, 2024
This was referenced Feb 7, 2024
Closed
Closed
There was a problem hiding this comment.
@ejweber Sorry for the delay. Let me know if you have concerns about the changes.
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
content/docs/1.7.0/nodes-and-volumes/volumes/trim-filesystem.md
Outdated
Show resolved
Hide resolved
ejweber
force-pushed
the
7103-further-explain-trim-issues
branch
from
61201e1
to
7ffbb70
Compare
innobead
requested changes
Feb 19, 2024
Longhorn 7103 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 7103 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
7103-further-explain-trim-issues
branch
from
7ffbb70
to
7c55fe1
Compare
Longhorn 7103 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
7103-further-explain-trim-issues
branch
from
7c55fe1
to
113d9dd
Compare
Done, with minor changes related to organization and missing features in previous versions. |
innobead
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#7103
What this PR does / why we need it:
I wanted to clarify the effects of longhorn/longhorn-engine#1008. In addition, there were a few things in this doc that confused me when I read it at the start of working on longhorn/longhorn#7103.