doc(backup): manually synchronize backup volumes #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@mantissahz Let me know if you have concerns about the changes.
...t/docs/1.6.2/snapshots-and-backups/backup-and-restore/synchronize_backup_volumes_manually.md
Outdated
Show resolved
Hide resolved
...t/docs/1.6.2/snapshots-and-backups/backup-and-restore/synchronize_backup_volumes_manually.md
Outdated
Show resolved
Hide resolved
...t/docs/1.6.2/snapshots-and-backups/backup-and-restore/synchronize_backup_volumes_manually.md
Outdated
Show resolved
Hide resolved
Ref: longhorn/longhorn 7982 Signed-off-by: James Lu <james.lu@suse.com>
jillian-maroket
approved these changes
May 23, 2024
innobead
approved these changes
May 24, 2024
There was a problem hiding this comment.
In general, LGTM.
Beyond the topic, there is one thing we need to improve. Sometimes we use backup target but sometimes backup store. It seems better to use only one terminology. cc @jillian-maroket @derekbit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#7982
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context