Maintain shadow background during photo clipping #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a property should be added to control this. I want the user to be able to clearly see all areas of the image when dragging the crop area. |
patryk-sredzinski
force-pushed
the
feature/maitain-shadow-background-during-clipping-photo
branch
from
c790c31
to
fa8c474
Compare
|
@longitachi I've added property called:
Tell me if you'd like me to do some other changes :) |
patryk-sredzinski
force-pushed
the
feature/maitain-shadow-background-during-clipping-photo
branch
from
e97df6a
to
ea84b42
Compare
patryk-sredzinski
force-pushed
the
feature/maitain-shadow-background-during-clipping-photo
branch
from
ea84b42
to
d923820
Compare
longitachi
reviewed
Sep 5, 2023
longitachi
reviewed
Sep 5, 2023
patryk-sredzinski
force-pushed
the
feature/maitain-shadow-background-during-clipping-photo
branch
from
5fd1f97
to
8a69cdf
Compare
longitachi
approved these changes
Sep 5, 2023
patryk-sredzinski
deleted the
feature/maitain-shadow-background-during-clipping-photo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to keep the shadow visible all the time during photo clipping. Got it working well.
We can add a property so the user can decide if he want to see it or not, but for now I've decided to leave it as it is.
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-31.at.13.13.58.mp4