Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate spkac signature #1

Merged
merged 3 commits into from Feb 15, 2017
Merged

Validate spkac signature #1

merged 3 commits into from Feb 15, 2017

Commits on Feb 15, 2017

  1. Fix test lint problems: Use t.Errorf for format strings

    @asf-stripe
    asf-stripe committed Feb 15, 2017
    Copy the full SHA
    257e496 View commit details
    Browse the repository at this point in the history

  2. Update return types to be crypto.PublicKey 

    Type checking will not be any more strict, but we can at least
communicate to the user of this package what they can expect back.
    @asf-stripe
    asf-stripe committed Feb 15, 2017
    Copy the full SHA
    c8f8ca4 View commit details
    Browse the repository at this point in the history

  3. New function: ValidateSPKAC: parse SPKACs and check their signatures 

    Given a sufficiently-modern SPKAC (provided you're not using one with
an outdated/broken message digest), you can have go validate the
signature on it, so this gives us that capability.

The main annoyance with this is that openssl can't generate these
SPKACs as far as I can tell - for testing, you have to take ones from
a source that is known to generate "good" ones.
    @asf-stripe
    asf-stripe committed Feb 15, 2017
    Copy the full SHA
    a9888d5 View commit details
    Browse the repository at this point in the history