Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when declaring war would imply cancelling alliances #2177

Closed
lmoureaux opened this issue Jan 27, 2024 · 0 comments · Fixed by #2266
Closed

Warn when declaring war would imply cancelling alliances #2177

lmoureaux opened this issue Jan 27, 2024 · 0 comments · Fixed by #2266
Labels
enhancement New feature or request server This issue requires changes to the server
Milestone
v3.1-stable

Comments

@lmoureaux
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In games with complex alliance systems, declaring war (or cease-fires running out) can have unintended consequences.

Describe the solution you'd like

  • When war would result in an alliance being cancelled, require the user to cancel the alliance first.
  • When a cease-fire running out would result in an alliance being cancelled, automatically lengthen the cease-fire until the alliance gets cancelled.

Describe alternatives you've considered

Message boxes asking for confirmation. It sounds more difficult to implement for no additional functionality.

Additional context

Happened twice in SG2 already...
@lmoureaux lmoureaux added enhancement New feature or request server This issue requires changes to the server labels Jan 27, 2024
@lmoureaux lmoureaux added this to the v3.1-stable milestone Jan 27, 2024
@lmoureaux lmoureaux mentioned this issue Feb 3, 2024
Open
blabber added a commit to blabber/freeciv21 that referenced this issue Mar 15, 2024
@blabber
Prevent user from declaring war if it would break alliances
a933466 
Part of longturn#2177.
blabber added a commit to blabber/freeciv21 that referenced this issue Mar 15, 2024
@blabber
Prevent user from declaring war if it would break alliances
d39e97d 
Part of longturn#2177.
blabber added a commit to blabber/freeciv21 that referenced this issue Mar 15, 2024
@blabber
Prevent user from declaring war if it would break alliances
e8edaf3 
Part of longturn#2177.
@blabber blabber mentioned this issue Mar 15, 2024
Merged
blabber added a commit to blabber/freeciv21 that referenced this issue Mar 18, 2024
@blabber
Prevent user from declaring war if it would break alliances
4f389e5 
In games with complex alliance systems, declaring war can have
unintended consequences. To protect the user from cancelling alliances
by accident:

* When declaring war would result in an alliance being cancelled,
  require the user to cancel the alliance first.
* When declaring war would force one of your team mates to cancel an
  existing alliance, require this alliance to be cancelled first.

Part of longturn#2177.
lmoureaux pushed a commit that referenced this issue Mar 26, 2024
@blabber @lmoureaux
Prevent user from declaring war if it would break alliances
ecd275d 
In games with complex alliance systems, declaring war can have
unintended consequences. To protect the user from cancelling alliances
by accident:

* When declaring war would result in an alliance being cancelled,
  require the user to cancel the alliance first.
* When declaring war would force one of your team mates to cancel an
  existing alliance, require this alliance to be cancelled first.

Part of #2177.
@blabber blabber mentioned this issue Mar 26, 2024
Closed
2 tasks
@blabber blabber mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request server This issue requires changes to the server
Projects
None yet
Milestone
v3.1-stable
Development

Successfully merging a pull request may close this issue.

Add some protection measures for a players alliances blabber/freeciv21
1 participant
@lmoureaux