Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for math usage in the documenation #1837

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

lmoureaux
Copy link
Contributor

Keep the topic short because math should be used sparingly. In particular, a full Latex reference is out of scope here; Latex is widespread enough that there are countless resources on the topic. The syntax is also way to complex to explain in a single page.

Closes #1719.

@jwrober
Copy link
Collaborator

jwrober commented Feb 23, 2023

That was fast :)

Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. My only comment would be to aid the reader with a link to a "good source" to help those that might be overwhelmed with all the LaTeX documentation to know which one to use.

I do like the "use sparingly" comment. Maybe more emphasis on usage in the coding section is appropriate, while in manuals is probably not appropriate as an example?

Keep the topic short because math should be used sparingly. In particular, a
full Latex reference is out of scope here; Latex is widespread enough that
there are countless resources on the topic. The syntax is also way to complex
to explain in a single page.

Closes longturn#1719.
@lmoureaux
Copy link
Contributor Author

My only comment would be to aid the reader with a link to a "good source" to help those that might be overwhelmed with all the LaTeX documentation to know which one to use.

Added a Wikibooks I learned a lot from, it's however more a reference than a tutorial.

Maybe more emphasis on usage in the coding section is appropriate, while in manuals is probably not appropriate as an example?

Given how often we get questions about the price of unit upgrades, I think we shouldn't push back too hard on math in "normal" docs.

@jwrober
Copy link
Collaborator

jwrober commented Feb 25, 2023

Given how often we get questions about the price of unit upgrades, I think we shouldn't push back too hard on math in "normal" docs.

Simple formulas I think are fine anywhere. It's the super complex ones that we have in the coding area that I think need to stay there. "Normal" docs should be readable by anyone with Algebra I level math knowledge (e.g. what every US high school teaches).

@lmoureaux
Copy link
Contributor Author

Wording suggestion?

@jwrober
Copy link
Collaborator

jwrober commented Feb 25, 2023

When math formulas are used on non-technical pages (such as any one of the manuals), the reasoning should be relatively simple following elementary algebra [https://en.wikipedia.org/wiki/Elementary_algebra]

@lmoureaux lmoureaux enabled auto-merge (rebase) February 26, 2023 14:27
@lmoureaux lmoureaux merged commit 0c17136 into longturn:master Feb 26, 2023
@lmoureaux lmoureaux deleted the docs/formulas branch February 26, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the usage of latex math
2 participants