Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <releases> tag to client metainfo.xml file #2000

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Jul 12, 2023

No related issue. Will make future flatpak updates easier.

@jwrober jwrober requested a review from lmoureaux July 12, 2023 20:11
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generate this automatically so we don't need to remember to update it for every release?
I guess we should set it consistently in all metainfo files, not only the client one.

@lmoureaux
Copy link
Contributor

Oh, and since there's a validation tool for Flatpak, it would be good to run it in the CI (can be a later project though).

@jwrober
Copy link
Collaborator Author

jwrober commented Jul 12, 2023

Note this is for stable. For now I think leaving it manual in stable branch is the better approach. I don't want to upset the apple cart so to speak. I want to automate it in all the files w/ CI checks in develop/master branch where we have plenty of time to work out any bugs.

Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry had missed the target branch!

@lmoureaux lmoureaux added the back-port back-port candidate label Jul 12, 2023
@jwrober jwrober merged commit f720d44 into longturn:stable Jul 12, 2023
15 of 16 checks passed
@jwrober jwrober deleted the appstream branch January 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port back-port candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants