Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing orders should be acknowledged by a button #88

Closed
gereon77 opened this issue Jan 13, 2020 · 1 comment · Fixed by #283 or #583
Closed

Changing orders should be acknowledged by a button #88

gereon77 opened this issue Jan 13, 2020 · 1 comment · Fixed by #283 or #583
Labels
type:qol Quality of life improvements

Comments

@gereon77
Copy link
Collaborator

Right now you only have to acknowledge your orders the first time. Any changes to your orders are sent directly to the server which might lead to a critical state.
It would be better if your changes will be submitted on a button which appears when you changed your already sent orders.

@Longwelwind Longwelwind added priority:medium type:qol Quality of life improvements labels Jan 15, 2020
@Longwelwind
Copy link
Owner

To implement this, I think the best way is to:

  • When the server receive a message from the player, it unreadies the player if he was ready. Client-side, this can also be checked and the payer can be unreadied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:qol Quality of life improvements
Projects
None yet
2 participants