Nullify references once not used to prevent double-frees #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, it looks self-explaining.
In a couple of places, we check if the value is NULL and free() it.
However, if we start/stop the profiler a couple of times, the next time we (potentially) may not allow the value but still will try to free it and corrupt memory.
The issue with
XHPROF_G(root)
happened on our production, it was corrupting memory in another place (as the freed() chunk was given to another code), the problem withnames[i]
can be seen if we run tests having PHP built with--enable-debug
.Could you please take a look and let me know if there's something I can improve?