Review: import a few Java files

[GoogleCodeExporter]

Initial import of a few Java files, asking for a code review.

Original issue reported on code.google.com by feng.qia...@gmail.com on 25 Aug 2006 at 11:02

Attachments:

• common_interfaces.diff

[GoogleCodeExporter]

You should add a license block to the top of each file.  Other than that, looks 
good.
 r=me.

Original comment by mmento...@gmail.com on 26 Aug 2006 at 2:43

• Changed title: Review: import a few Java files

[GoogleCodeExporter]

Sorry, I send out files in a wrong directory. I made copyright changes in 
another
working directory already. Now I re-attach the diff here. In this diff, I added 
all
Java files under java/common/src/com/google/airbag/common, and a build.xml 
script.

The code doesn't compile yet, because it depends on servlet api. A third-party
library will be checked in later.

I am curious what tools you used to do review. Is it hard?

Thanks.

Original comment by feng.q...@gmail.com on 28 Aug 2006 at 5:49

Attachments:

• airbugcommon.diff

[GoogleCodeExporter]

Original comment by mmento...@gmail.com on 29 Aug 2006 at 7:25

[GoogleCodeExporter]

Original comment by mmento...@gmail.com on 29 Aug 2006 at 8:45

• Changed state: Fixed