Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Borrow use #18

Open
lonnen opened this issue Apr 2, 2020 · 1 comment
Open

fix Borrow use #18

lonnen opened this issue Apr 2, 2020 · 1 comment

Comments

@lonnen
Copy link
Owner

lonnen commented Apr 2, 2020

Even with the documented claims removed, there's inconsistent use of Borrow and Sized in some of the basic app functionality. Let's clean that up, and then ship a dot release.

see also: #15
lonnen added a commit that referenced this issue Apr 13, 2020
@lonnen
remove get_mut function, unconstrain get_element_multiplicty
8d9611e 
get_mut is uneccesary with *_times methods.

the borrow constraint on get_element_multiplicity doesnt make any sense at all. step one towards figuring out borrows (issue #15 issue #18)
@lonnen
Copy link
Owner Author

lonnen commented May 12, 2020

0.0.3 fixes this for remove and remove_times. Maybe there are other places still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lonnen