Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development toolkit #383

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Update development toolkit #383

merged 1 commit into from
Jun 21, 2021

Conversation

MGatner
Copy link
Collaborator

@MGatner MGatner commented Jun 21, 2021

  • Updates PHPUnit test parameters for tighter testing
  • Adds Infection for mutation testing (test quality testing)
  • Adds RoaveBC to detect breaking changes
  • Adds Tachycardia for slow test detection and annotation
  • Adds Coveralls upload to Action workflow
  • Switches code style enforcement to PHP CS Fixer to match the framework (awaiting configuration)

Copy link
Owner

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it but I think we need to raise the limit on the slow tests since password/encryption is always slower if it's strong.

@MGatner
Copy link
Collaborator Author

MGatner commented Jun 21, 2021

raise the limit on the slow tests

For sure. This can be done per test class or per test method. For now it won't hurt anything (i.e. nothing "fails") until someone can go through and figure out which are actually slow tests and which will always be that way.

@MGatner MGatner merged commit 9c0152e into lonnieezell:develop Jun 21, 2021
@MGatner MGatner deleted the tools branch June 21, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants