Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BaseFilter not found error after publishing filters from cli #571

Closed
wants to merge 2 commits into from
Closed

Conversation

manageruz
Copy link
Collaborator

This will add 'use Myth\Auth\Filters\BaseFilter;' import to the all three filter files after publishing them by auth:publish command.

@manageruz
Copy link
Collaborator Author

Fixes #568

@manageruz
Copy link
Collaborator Author

Closes #569

@manageruz
Copy link
Collaborator Author

Waiting for review from @MGatner

@manageruz
Copy link
Collaborator Author

Here is still PHPStan and Rector errors. Extending BaseController instead of Controller will fix first one.

@MGatner
Copy link
Collaborator

MGatner commented Oct 8, 2022

Let's deal with the pipeline issues in a separate PR, then this will be much easier to pass and review. I can help with that later today, but it looks like you have a good start if you want to make a new branch and cherry-pick your commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants