Skip to content

Commit

Permalink
Remove outdated caching from production environment
Browse files Browse the repository at this point in the history
config.action_view.cache_template_loading was removed for Rails 3. It
may be making a comeback in Rails 3.1, but we don't live there yet. See
http://railsforum.com/viewtopic.php?id=23648 and
https://rails.lighthouseapp.com/projects/8994/tickets/5847-rails-301-configaction_viewcache_template_loading-is-missing

The default is to use /public/cache for cached content, so explicitly
setting config.action_controller.page_cache_directory = Rails.root +
"/public/cache/" is unnecessary.
  • Loading branch information
Lonnon Foster committed Feb 14, 2011
1 parent 8ae9144 commit 0d10016
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions templates/module.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
environment 'SITE_DOMAIN="localhost:3000"', :env => "development"
environment 'SITE_DOMAIN="localhost:3000"', :env => "test"
environment 'SITE_DOMAIN="localhost:3000"', :env => "production"
environment 'config.action_view.cache_template_loading = false', :env => "production"
environment 'config.action_controller.page_cache_directory = Rails.root + "/public/cache/"', :env => "production"
rake "db:migrate"

git :init
Expand Down

2 comments on commit 0d10016

@peakpg
Copy link

@peakpg peakpg commented on 0d10016 May 4, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm going to probably grab these changes for 3.4, though the file they are in now has changed, so I would have to apply them manually (They are in bin/bcms in HEAD). I can manually apply them if that easier than you merging the upstream commits/sending me a pull request.

@lonnon
Copy link
Owner

@lonnon lonnon commented on 0d10016 May 5, 2011 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.