Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Enumerable#grep to filter by type #487

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

olleolleolle
Copy link
Contributor

This reformulates a tiny part of the code to use an existing Ruby method.

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for lookbook-docs canceled.

Name Link
🔨 Latest commit 59788dc
🔍 Latest deploy log https://app.netlify.com/sites/lookbook-docs/deploys/64870cd5efb798000812c413

@allmarkedup
Copy link
Collaborator

Hey @olleolleolle, really sorry it's taken me so long to take a look at this.

I did not know about Enumerable#grep but this is so much nicer, thank you! The only problem is now I want to go through all my Ruby code to see where I can use it to clean things up a bit... :)

Will merge now, much appreciated.

@allmarkedup allmarkedup merged commit c0ed083 into lookbook-hq:main Jul 6, 2023
21 checks passed
@olleolleolle olleolleolle deleted the refactor-to-grep branch July 6, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants