Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs no longer show scrollbar when overflowing #1295

Merged
1 commit merged into from Aug 4, 2020
Merged

Tabs no longer show scrollbar when overflowing #1295

1 commit merged into from Aug 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2020 •
edited by ghost

✨ Changes

  • Tabs no longer show scrollbar when overflowing

Before

image

NOTE: To emulate this behavior for easy testing switch "System Preferences > General" "Show Scroll bars" to "Always"

image

After

image

✅ Requirements

  • Includes test coverage for all changes
  • Build and tests are passing
  • Update documentation
  • Updated CHANGELOG
  • Checked for i18n impacts
  • Checked for a11y impacts
  • PR is ideally < ~400LOC

📷 Screenshots

@ghost ghost requested a review from jhardy August 4, 2020 20:36
@ghost ghost merged commit c116eec into master Aug 4, 2020
@ghost ghost deleted the luke/tabs-no-visible-scrollbar branch August 4, 2020 21:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jhardy