Exemption for custom rules

[ajbosco]

Is it possible to set granular exemptions for custom rules? I tried something like this, but it didn't seem to work:

    # LAMS
    # rule_exemptions: {
    #  my_custom_rule: "2018-11-12 - I can't use datagroups for this super special reason and Bob said it's ok"
    # }

[fabio-looker]

It should be... I'll double check this week

[fabio-looker]

Hi @ajbosco - I tested this late last week, and you were right, there was not yet any support for exemption (granular or global) of custom rules.

I have added the ability to support granular exemptions (and inherited but not global) in the exempt-custom-rules branch.

You can see a test for the functionality here: https://github.com/looker-open-source/look-at-me-sideways/tree/exempt-custom-rules/__tests__/dummy-projects/09-exempt-custom-rules

Would you like to review this before I publish the update to NPM?

[ajbosco]

@fabio-looker Awesome. Looks good to me!

[fabio-looker]

Thanks! The new feature is in version 1.6+ on npm

[fabio-looker]

Hi @ajbosco - Since I see you are using custom rules, I thought you might appreciate the new Rule Sandbox that helps with writing/testing custom rules:

https://looker-open-source.github.io/look-at-me-sideways/tools/rule-sandbox/

Hopefully it's helpful to you!