Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Updated Kotlin from version 1.7.0 to 1.8.20 and respective linter/formatter tool #1284

Conversation

daniel-lopes-optimizely
Copy link
Contributor

This PR upgrades:

  • the Gradle version - the build files were rewritten in Kotlin for type safety
  • the Kotlin version, from 1.7.x to 1.8.x
  • the Kotlin coroutine library version, from release candidate to the latest stable version
  • the code linting gradle plugin and ktlint version, which prompted a code reformat

Please have a look and let me know how I can further support this PR.

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #1277 🦕

@jkaster
Copy link
Contributor

jkaster commented Apr 4, 2023

Thanks for this! Sorry for the update dance, but could you resolve the conflicts again and I'll get the CI run submitted and try the branch myself?

@daniel-lopes-optimizely daniel-lopes-optimizely changed the title chore(deps): Updated Kotlin from version 1.7.0 to 1.8.10 and respective linter/formatter tool chore(deps): Updated Kotlin from version 1.7.0 to 1.8.20 and respective linter/formatter tool Apr 4, 2023
@daniel-lopes-optimizely
Copy link
Contributor Author

Hello @jkaster I've resolved the conflicts, should be good to take look now.

@jeremytchang
Copy link
Collaborator

Created a pr with your changes/commit @daniel-lopes-optimizely to trigger our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Kotlin, Koroutines, Gradle, Formatting
3 participants