Fixed decoded URI handling inside DavResource constructor #253
Conversation
|
The build failed because some URLs in the test like http://sardine.googlecode.com/svn/trunk/README.html are not available (404). |
|
Hrefs in the XML response are already required to be URI encoded per the RFC specification. With this patch, the references end up double encoded for servers that comply to the specification. |
|
So... our Microsoft Sharepoint server does not comply to the specification? |
|
@Holdo Right. |
|
Cool. Can we put my alternative (re-try) in the URISyntaxException catch block? |
|
I updated the commit to give the parsing a second chance. |
|
This should be ammended with a unit test. I suppose this is not correct as we should use URI encoding (not |
In SardineImpl.enablePreemptiveAuthentication(String, int, int, Charset), do not pass -1 to the HttpHost constructor. The later cache lookup is always done with an explicit port, so port -1 never matches and the entry does nothing. Instead, we need to use the default port explicitly, then it will work, even when connecting with a URL that does not include the port. Since the other overloads delegate to this one, this fixes all overloads to do the right thing, in particular, the enablePreemptiveAuthentication(String) (hostname-only) and enablePreemptiveAuthentication(URL) (when using a URL without an explicit port) ones. Fixes lookfirst#253.
|
Sorry, wrong issue number in my pull request, so it ended up referencing this pull request. |
This fixes URI encoding related problems like white spaces in the DavResource class. I had a problem with listing files on a shared drive URI which included white spaces.
I did not run the tests (they depend on http://test.cyberduck.ch which was not available).
There is a new exception UnsupportedEncodingException, which I handled in SyncCollectionReport class but it is being propagated via IOException in the DavResource class.