Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name to manifest #367

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

blutorange
Copy link
Contributor

Add Automatic-Module-Name to manifest, see http://branchandbound.net/blog/java/2017/12/automatic-module-name/ Without an explicit name, the compiler will warn when attempting to use this library

[INFO] --- compiler:3.11.0:compile (default-compile) @ simple-servlet-container-tests-common ---
[WARNING] ****************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [sardine-5.10.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] ****************************************************************************************************************************************

@lookfirst
Copy link
Owner

Doesn't seem like it can do much harm.

@lookfirst lookfirst merged commit 8fd48d5 into lookfirst:master Apr 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants